Automatically promote input variables in BTOR2 constraints #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BTOR2 input format allows constraints containing input variables. This requires promoting those input variables to state variables within Pono's infrastructure (which does not allow input variables in any invariant constraints, the initial states, or the property). The reason for this is that inputs are supposed to only be affiliated with a transition, so it doesn't make sense to have an invariant constraint over them which refers to sets of states. However, this might be worth revisiting.