-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add --ignore
option
#317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I honestly thought, we already supported the --ignore
option. 😄
Overall changes, looks good to me. 👍
About the check:installed-check
, I'd rather still support Node.js v12 to avoid the breaking change and in package.json
, set "dependency-check": "5.0.0-4",
, without the ^
.
This will allow us, to release it as standard-engine
v15.1.0 and also release it quicker for the different engines like ts-standard
. Thoughts @voxpelli?
Should work to just use the ignore flag in installed-check to have it ignore dependency-check, the dev deps are not as crucial and dependency-check will quit silently on unsupported node versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! 👍
Thank you @voxpelli |
Good day |
I'll try to get to it next week, I'm crunching g towards a Christmas deadline right now, if it hasn't been released by next week, then ping me here again (I want GitHub to add a snooze feature 😝) |
friendly ping @voxpelli |
friendly ping @voxpelli ❤️ |
Released in |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added
--ignore
flag support.I'd like to run linter separately for unit-tests:
Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to focus on?
I had to change
engines
setup inpackage.json
becausecheck:installed-check
script fails otherwise:this comes from the following
dependency-check
commit - dependency-check-team/dependency-check@e88ae34I'd love to see this feature within the current major version, but I doubt this is going to be blessed due to drop of node-12. Is there an option to avoid a major version bump, or should I just go ahead and make it
"version": "16.0.0"
?