Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid hardcoding boost::ecuyer1988 #1395

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Avoid hardcoding boost::ecuyer1988 #1395

merged 1 commit into from
Jan 31, 2024

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Documentation
    • If a user-facing facing change was made, the documentation PR is here:
    • OR, no user-facing changes were made

Release notes

Follow on to stan-dev/stan#3263. The generated C++ no longer assumes that the RNG used in Stan is specifically the boost::ecuyer1988 generator, but uses a type alias defined in the Stan library.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f2dbe7) 89.88% compared to head (6ac9fde) 89.88%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1395   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files          63       63           
  Lines       10505    10505           
=======================================
  Hits         9442     9442           
  Misses       1063     1063           
Files Coverage Δ
src/stan_math_backend/Lower_functions.ml 98.64% <100.00%> (ø)
src/stan_math_backend/Lower_program.ml 99.18% <100.00%> (ø)

@WardBrian WardBrian marked this pull request as ready for review January 31, 2024 16:36
Copy link
Contributor

@SteveBronder SteveBronder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@WardBrian WardBrian merged commit d576a16 into master Jan 31, 2024
3 checks passed
@WardBrian WardBrian deleted the code-gen/rng_t branch January 31, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants