Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3247 json metric type - add field "metric_type" to metric.json file #3248

Merged
merged 7 commits into from
Dec 11, 2023

Conversation

mitzimorris
Copy link
Member

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Add field "metric_type" with values "diag_e", "dense_e", and "unit_e" to json metric file.

Intended Effect

Make it easier to restart sampler - always specify metric type.

How to Verify

Unit tests will be added to CmdStan's tests of this feature once this PR is merged.

Side Effects

N/A

Documentation

N/A

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides testing further downstream in cmdstan, we are testing the rest of this feature in the following files:

src/test/unit/services/sample/hmc_nuts_unit_e_adapt_parallel_test.cpp
src/test/unit/services/sample/hmc_nuts_diag_e_adapt_parallel_match_test.cpp
src/test/unit/services/sample/hmc_nuts_dense_e_adapt_parallel_match_test.cpp

I think we should add the test that this is output as expected to those three files. Should be short for each of them

src/stan/mcmc/hmc/base_hmc.hpp Show resolved Hide resolved
@mitzimorris
Copy link
Member Author

changes made; ready for re-review

@mitzimorris mitzimorris merged commit bf25b49 into develop Dec 11, 2023
3 checks passed
@WardBrian WardBrian deleted the feature/3247-json-metric-type branch December 11, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants