Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds size checking to uni index array assignment #3218

Merged
merged 7 commits into from
Aug 9, 2023

Conversation

SteveBronder
Copy link
Collaborator

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Fixes #3150 to do a size check when assigning to the inner elements of an array whose inner elements also have dimensions.

Intended Effect

Stop the use of accidental ragged arrays

How to Verify

New test added that can be run with

python ./runTests.py -j18 ./src/test/unit/model/indexing/assign_test.cpp

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian merged commit 0335c9a into develop Aug 9, 2023
2 checks passed
@WardBrian WardBrian deleted the fix/assign-size-check branch August 9, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign size-checking not occurring for arrays of vectors
4 participants