Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Tuple indices in Stan CSV Header Reader #3190

Merged
merged 8 commits into from
May 8, 2023

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

With Tuples, it will no longer be the case that names will always look like x.1.2.1. You can also have a tuple separator indicated by :.

So, for example, a Stan expression x.1[1] will have header x:1.1, y[2].1[3] will be y.2:1.3

Intended Effect

Allow names with : in them for tuples to be parsed properly in the CSV reader

How to Verify

New test added with a header generated by the current compiler branch for Tuples

Side Effects

I also removed some functions no longer needed after #3179

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Collaborator

@SteveBronder SteveBronder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment but otherwise looks good!

src/stan/io/stan_csv_reader.hpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants