Support Tuple indices in Stan CSV Header Reader #3190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
With Tuples, it will no longer be the case that names will always look like
x.1.2.1
. You can also have a tuple separator indicated by:
.So, for example, a Stan expression
x.1[1]
will have headerx:1.1
,y[2].1[3]
will bey.2:1.3
Intended Effect
Allow names with
:
in them for tuples to be parsed properly in the CSV readerHow to Verify
New test added with a header generated by the current compiler branch for Tuples
Side Effects
I also removed some functions no longer needed after #3179
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: