Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expose_functions under 2.32 #769

Merged
merged 5 commits into from
May 30, 2023
Merged

Fix expose_functions under 2.32 #769

merged 5 commits into from
May 30, 2023

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Fixes compatibility with cmdstan 2.32 for exposing functions

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2023

Codecov Report

Merging #769 (0b5b201) into master (ab30e07) will decrease coverage by 2.05%.
The diff coverage is 83.33%.

❗ Current head 0b5b201 differs from pull request most recent head b189bc8. Consider uploading reports for the commit b189bc8 to get more accurate results

@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
- Coverage   88.26%   86.22%   -2.05%     
==========================================
  Files          12       12              
  Lines        4117     4130      +13     
==========================================
- Hits         3634     3561      -73     
- Misses        483      569      +86     
Impacted Files Coverage Δ
R/fit.R 96.06% <ø> (ø)
R/utils.R 72.34% <82.75%> (-2.23%) ⬇️
R/model.R 90.45% <100.00%> (-0.14%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andrjohns
Copy link
Collaborator Author

@rok-cesnovar this is ready for a look. The windows test failures here (messages being printed when not interactive()) are the same ones from master and need to be sorted separately

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@andrjohns andrjohns merged commit 01aa7f1 into master May 30, 2023
@jgabry
Copy link
Member

jgabry commented May 31, 2023

Thanks @andrjohns!

@jgabry jgabry deleted the v2.32-compat branch May 31, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants