Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exposing functions with int return types #742

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

This PR addresses #740 to fix exposing functions with int return types. I've also expanded the test to more thoroughly assess compatibility with different types

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

Codecov Report

Merging #742 (df389a2) into master (463c2de) will increase coverage by 2.16%.
The diff coverage is 100.00%.

❗ Current head df389a2 differs from pull request most recent head 52e22f5. Consider uploading reports for the commit 52e22f5 to get more accurate results

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   86.09%   88.25%   +2.16%     
==========================================
  Files          12       12              
  Lines        4071     4071              
==========================================
+ Hits         3505     3593      +88     
+ Misses        566      478      -88     
Impacted Files Coverage Δ
R/utils.R 74.01% <100.00%> (+1.96%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks @andrjohns.

@rok-cesnovar rok-cesnovar merged commit 9169245 into master Mar 22, 2023
@rok-cesnovar rok-cesnovar deleted the fix-expose-int branch June 26, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants