Improve efficiency of variable matching #736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Improve the efficiency of variable matching to fix #735. This is done by first checking for exact matches and removing any matches from the following loop.
As far as I can tell this retains the exact same functionality. The example in #735 runs in under 10s vs. >2mins before. All relevant tests seem to pass.
Copyright and Licensing
Sebastian Funk
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: