Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSL Optimisations and Bugfixes for CI #711

Merged
merged 15 commits into from
Nov 7, 2022
Merged

WSL Optimisations and Bugfixes for CI #711

merged 15 commits into from
Nov 7, 2022

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

This PR includes a number of small optimisations and bugfixes to the WSL backend

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Merging #711 (cb9ce8f) into master (09a9be2) will decrease coverage by 0.12%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
- Coverage   88.46%   88.33%   -0.13%     
==========================================
  Files          12       12              
  Lines        4023     4030       +7     
==========================================
+ Hits         3559     3560       +1     
- Misses        464      470       +6     
Impacted Files Coverage Δ
R/model.R 90.49% <0.00%> (-0.13%) ⬇️
R/run.R 94.40% <0.00%> (-0.15%) ⬇️
R/csv.R 96.44% <14.28%> (-1.23%) ⬇️
R/utils.R 73.84% <100.00%> (+0.32%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andrjohns
Copy link
Collaborator Author

Nice to finally see all of the test results in green again!

@andrjohns
Copy link
Collaborator Author

And before I forget - if you do release notes or similar for the next release, it would be good to mention that the new model methods (log_prob etc) and exposing UDF features aren't WSL-compatible just yet (since the cmdstan libraries for the TBB and Sundials are built under linux so R can't link to them under Windows)

@rok-cesnovar
Copy link
Member

Will do! Thanks a ton, @andrjohns! This looks great, nice to have the green back :)

@rok-cesnovar rok-cesnovar merged commit afd15a8 into stan-dev:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants