Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1189 pathfinder diagnostics #1190

Merged
merged 9 commits into from
Aug 25, 2023

Conversation

mitzimorris
Copy link
Member

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Added logic to check for diagnostic_file argument when setting flag save_iterations to command.hpp,
plus unit test.

Intended Effect:

fix #1189

How to Verify:

unit tests

Side Effects:

N/A

Documentation:

N/A

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

src/cmdstan/command.hpp Outdated Show resolved Hide resolved
@WardBrian
Copy link
Member

CI failure is from bogus warnings, so I'm merging

@WardBrian WardBrian merged commit 5c0b7b2 into develop Aug 25, 2023
1 check failed
@WardBrian WardBrian deleted the bugfix/1189-pathfinder-diagnostics branch August 25, 2023 18:36
@WardBrian WardBrian mentioned this pull request Aug 25, 2023
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pathfinder: save diagnostics when num_paths=1, save_single_paths=0 and arg diagnostics_file specified
3 participants