systemd/service: remove unused and deprecated PermissionsStartOnly #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remember to change the redundant service file inside install.sh too, as #389 is not merged. |
This setting has been deprecated in systemd 240. It didn't seem to be actually useful since there's no `Exec*` other than ExecStart being defined here.
pacien
force-pushed
the
systemd-remove-permissionsstartonly
branch
from
a61ec1a
to
6e292b3
Compare
|
Quoting Lukas Lihotzki (2024-06-20 18:51:45)
Remember to change the redundant service file inside install.sh too, as #389 is not merged.
Good catch, this is now amended 👍
|
13 tasks
Shawn8901
pushed a commit
to Shawn8901/nixpkgs
that referenced
this pull request
Jun 22, 2024
We're using the upstream systemd service file since dfa130e. It specifies `PermissionsStartOnly = true`, which is not only deprecated in recent systemd, but also interferes with the `ExecPreStart` in our module. This adds a patch to the package solving this, allowing our module and NixOS test to work until this gets merged upstream. Upstream PR: stalwartlabs/mail-server#528
happysalada
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Jun 23, 2024
We're using the upstream systemd service file since dfa130e. It specifies `PermissionsStartOnly = true`, which is not only deprecated in recent systemd, but also interferes with the `ExecPreStart` in our module. This adds a patch to the package solving this, allowing our module and NixOS test to work until this gets merged upstream. Upstream PR: stalwartlabs/mail-server#528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting has been deprecated in systemd 240.
It didn't seem to be actually useful since there's no
Exec*otherthan ExecStart being defined here.