Make RSA key length configurable #506

maltesander · 2024-09-30T13:39:39Z

Description

fixes Increase RSA key length #465
used option 3 from decision https://github.com/stackabletech/decisions/issues/24

This is currently just a "pass-through" for the key length. The RSA / Key length structs could be moved into their own submodule, but since the whole part will be reworked with the operator-rs functionality, this was not done here.

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

Author

Give feedback

Changes are OpenShift compatible
CRD changes approved
CRD documentation for all fields, following the style guide.
Helm chart can be installed and deployed operator works
Integration tests passed (for non trivial changes)
Changes need to be "offline" compatible
Options

Reviewer

Give feedback

Code contains useful comments
Code contains useful logging statements
(Integration-)Test cases added
Documentation added or updated. Follows the style guide.
Changelog updated
Cargo.toml only contains references to git tags (not specific commits or branches)
Options

Acceptance

Give feedback

Feature Tracker has been updated
Proper release label has been added
Roadmap has been updated
Options

sbernauer

Thanks!

docs/modules/secret-operator/pages/secretclass.adoc

rust/operator-binary/src/crd.rs

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>

sbernauer

LGTM otherwise

rust/operator-binary/src/backend/tls/ca.rs

rust/operator-binary/src/crd.rs

Techassi

A few notes and questions.

deploy/helm/secret-operator/crds/crds.yaml

docs/modules/secret-operator/pages/secretclass.adoc

rust/operator-binary/src/backend/tls/ca.rs

rust/operator-binary/src/crd.rs

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>

…ackabletech/secret-operator into feat/make-tls-key-length-configurable

maltesander · 2024-10-01T09:46:20Z

test https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/secret-operator-it-custom/10/

sbernauer

LGTM, thanks!

rust/operator-binary/src/crd.rs

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>

sbernauer

LGTM to me, but please address @Techassi comments

Techassi

LGTM, mostly minor comments.

deploy/helm/secret-operator/crds/crds.yaml

docs/modules/secret-operator/pages/secretclass.adoc

rust/operator-binary/src/crd.rs

Co-authored-by: Techassi <sascha.lautenschlaeger@stackable.tech>

…ackabletech/secret-operator into feat/make-tls-key-length-configurable

Techassi

LGTM, one nit.

Techassi · 2024-10-02T10:54:32Z

rust/operator-binary/src/crd.rs

+#[serde(rename_all = "camelCase")]
+pub enum CertificateKeyGeneration {
+    Rsa {
+        /// The amount of bits used for generating the RSA keypair. 


nit: Use "key pair".

Suggested change

/// The amount of bits used for generating the RSA keypair.

/// The amount of bits used for generating the RSA key pair.

Beware: This requires a make regenerate-chart

make key length configurable

b2d77b7

maltesander requested review from nightkr and sbernauer September 30, 2024 13:39

maltesander self-assigned this Sep 30, 2024

maltesander added 10 commits September 30, 2024 15:41

adapted changelog

4e665b0

rename key length enum variants

9ff3c3c

cargo fmt

cec6a8d

fix unit tests

e7d344c

fmt

c0f96c2

improve crd schema

f2276c0

add comments

b0d7ae8

yaml lint

4f0fe53

add documentation

a89ecd4

improvements

58f9773

maltesander marked this pull request as ready for review September 30, 2024 15:05

fixes

abcd337

sbernauer requested changes Oct 1, 2024

View reviewed changes

maltesander and others added 4 commits October 1, 2024 09:11

Apply suggestions from code review

e89fc60

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>

set default key length to 2048

dd123af

adapt key length default and values

9f00f66

use constants for key length

ed80854

maltesander requested a review from sbernauer October 1, 2024 08:02

trailing whitespace

0fefa56

sbernauer requested changes Oct 1, 2024

View reviewed changes

rust/operator-binary/src/backend/tls/ca.rs Outdated Show resolved Hide resolved

rust/operator-binary/src/crd.rs Outdated Show resolved Hide resolved

rust/operator-binary/src/crd.rs Outdated Show resolved Hide resolved

Techassi requested changes Oct 1, 2024

View reviewed changes

maltesander and others added 5 commits October 1, 2024 11:05

Apply suggestions from code review

a4ee380

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>

explicitly use serde default

43edafe

Merge branch 'feat/make-tls-key-length-configurable' of github.com:st…

0c8b9d1

…ackabletech/secret-operator into feat/make-tls-key-length-configurable

improve docs

5fd3a46

fix clippy /test

e048894

fix test

1c9c728

sbernauer previously approved these changes Oct 2, 2024

View reviewed changes

rust/operator-binary/src/crd.rs Show resolved Hide resolved

Update rust/operator-binary/src/crd.rs

5873540

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>

maltesander dismissed sbernauer’s stale review via 5873540 October 2, 2024 07:53

maltesander requested a review from sbernauer October 2, 2024 07:53

maltesander added 2 commits October 2, 2024 09:54

regenerate charts

24bf088

bump tonic due to cargo deny

ccbfa4b

sbernauer previously approved these changes Oct 2, 2024

View reviewed changes

rename struct

077d2bb

maltesander dismissed sbernauer’s stale review via 077d2bb October 2, 2024 09:20

improve doc header

85ab8c4

sbernauer previously approved these changes Oct 2, 2024

View reviewed changes

Techassi requested changes Oct 2, 2024

View reviewed changes

Update deploy/helm/secret-operator/crds/crds.yaml

9a0b0b8

Co-authored-by: Techassi <sascha.lautenschlaeger@stackable.tech>

maltesander dismissed sbernauer’s stale review via 9a0b0b8 October 2, 2024 09:46

maltesander added 3 commits October 2, 2024 11:51

consistently switched to key pair instead of keypair

610cac8

Merge branch 'feat/make-tls-key-length-configurable' of github.com:st…

9b114c3

…ackabletech/secret-operator into feat/make-tls-key-length-configurable

improve docs

a819d63

maltesander requested a review from Techassi October 2, 2024 09:57

maltesander added 2 commits October 2, 2024 11:58

regenerate charts

18173d5

fix

2ea7649

Techassi previously approved these changes Oct 2, 2024

View reviewed changes

fix

b36cb6d

maltesander dismissed Techassi’s stale review via b36cb6d October 2, 2024 10:57

Techassi approved these changes Oct 2, 2024

View reviewed changes

maltesander added this pull request to the merge queue Oct 2, 2024

Merged via the queue into main with commit 9a23e70 Oct 2, 2024
31 checks passed

maltesander deleted the feat/make-tls-key-length-configurable branch October 2, 2024 11:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make RSA key length configurable #506

Make RSA key length configurable #506

maltesander commented Sep 30, 2024 •

edited

Loading

Author

Reviewer

Acceptance

sbernauer left a comment

sbernauer left a comment

Techassi left a comment

maltesander commented Oct 1, 2024

sbernauer left a comment

sbernauer left a comment

Techassi left a comment

Techassi left a comment

Techassi Oct 2, 2024 •

edited

Loading

	/// The amount of bits used for generating the RSA keypair.
	/// The amount of bits used for generating the RSA key pair.

Make RSA key length configurable #506

Make RSA key length configurable #506

Conversation

maltesander commented Sep 30, 2024 • edited Loading

Description

Definition of Done Checklist

Author

Reviewer

Acceptance

sbernauer left a comment

Choose a reason for hiding this comment

sbernauer left a comment

Choose a reason for hiding this comment

Techassi left a comment

Choose a reason for hiding this comment

maltesander commented Oct 1, 2024

sbernauer left a comment

Choose a reason for hiding this comment

sbernauer left a comment

Choose a reason for hiding this comment

Techassi left a comment

Choose a reason for hiding this comment

Techassi left a comment

Choose a reason for hiding this comment

Techassi Oct 2, 2024 • edited Loading

Choose a reason for hiding this comment

maltesander commented Sep 30, 2024 •

edited

Loading

Techassi Oct 2, 2024 •

edited

Loading