Skip to content

Commit

Permalink
improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
maltesander committed Sep 30, 2024
1 parent a89ecd4 commit 58f9773
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/modules/secret-operator/pages/secretclass.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Currently, only RSA is supported in the `autoTls` backend. You can however confi
include::example$secretclass-tls-key-length.yaml[]
----
<1> `autoTls.ca.keyGeneration` specifies which algorithm and additional parameters are used
<2> `autoTls.ca.keyGeneration.rsa` specifies the RSA algorithm
<2> `autoTls.ca.keyGeneration.rsa` specifies the RSA algorithm (RSA currently is the only one supported)
<3> `autoTls.ca.keyGeneration.rsa.length` specifies the amount of bits used for key or certs. Currently `2048`, `4096` and `8192` are supported.

Check notice on line 51 in docs/modules/secret-operator/pages/secretclass.adoc

View workflow job for this annotation

GitHub Actions / LanguageTool

[LanguageTool] docs/modules/secret-operator/pages/secretclass.adoc#L51

A comma may be missing after the conjunctive/linking adverb ‘Currently’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA[1]) Suggestions: `Currently,` URL: https://languagetool.org/insights/post/linking-words/ Rule: https://community.languagetool.org/rule/show/SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA?lang=en-US&subId=1 Category: PUNCTUATION
Raw output
docs/modules/secret-operator/pages/secretclass.adoc:51:94: A comma may be missing after the conjunctive/linking adverb ‘Currently’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA[1])
 Suggestions: `Currently,`
 URL: https://languagetool.org/insights/post/linking-words/ 
 Rule: https://community.languagetool.org/rule/show/SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA?lang=en-US&subId=1
 Category: PUNCTUATION

CAUTION: Using a key length higher than `2048` will significantly increase the computation time. If options higher than `2048` are choosen, the CPU

Check failure on line 53 in docs/modules/secret-operator/pages/secretclass.adoc

View workflow job for this annotation

GitHub Actions / misspell

[misspell] docs/modules/secret-operator/pages/secretclass.adoc#L53

"choosen" is a misspelling of "chosen"
Raw output
./docs/modules/secret-operator/pages/secretclass.adoc:53:131: "choosen" is a misspelling of "chosen"
Expand Down
4 changes: 2 additions & 2 deletions tests/templates/kuttl/tls/secretclass.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
autoGenerate: true
keyGeneration:
rsa:
length: {{ test_scenario['values']['tls-rsa-key-length'] }}
length: {{ test_scenario['values']['rsa-key-length'] }}
---
apiVersion: secrets.stackable.tech/v1alpha1
kind: SecretClass
Expand All @@ -30,5 +30,5 @@ spec:
autoGenerate: true
keyGeneration:
rsa:
length: {{ test_scenario['values']['tls-rsa-key-length'] }}
length: {{ test_scenario['values']['rsa-key-length'] }}
maxCertificateLifetime: 42h
4 changes: 2 additions & 2 deletions tests/test-definition.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dimensions:
values:
- "false"
- "true"
- name: tls-rsa-key-length
- name: rsa-key-length
values:
- 2048
- 4096
Expand All @@ -31,7 +31,7 @@ tests:
- openshift
- name: tls
dimensions:
- tls-rsa-key-length
- rsa-key-length
- openshift
- name: cert-manager-tls
dimensions:
Expand Down

0 comments on commit 58f9773

Please sign in to comment.