Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add labels to listener volume builder #799

Merged
merged 9 commits into from
Jun 3, 2024
Merged

feat!: Add labels to listener volume builder #799

merged 9 commits into from
Jun 3, 2024

Conversation

razvan
Copy link
Member

@razvan razvan commented May 28, 2024 •
edited by fhennig
Loading

Description

Part of stackabletech/issues#555

Required for stackabletech/hdfs-operator#534

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

@razvan razvan mentioned this pull request May 28, 2024
Merged
@razvan razvan marked this pull request as draft May 29, 2024 09:20
@razvan razvan marked this pull request as draft May 29, 2024 09:20
@razvan razvan marked this pull request as ready for review May 29, 2024 11:58
@razvan razvan requested a review from a team May 29, 2024 11:58
fhennig
fhennig previously approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@razvan razvan self-assigned this May 30, 2024
@razvan razvan marked this pull request as draft May 30, 2024 12:27
@razvan razvan marked this pull request as ready for review May 30, 2024 16:01
@razvan razvan requested a review from fhennig May 30, 2024 16:01
fhennig
fhennig approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@razvan razvan added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 9bdba1b Jun 3, 2024
17 checks passed
@razvan razvan deleted the bugfix/pvc-labels branch June 3, 2024 08:29
@Techassi Techassi mentioned this pull request Jun 3, 2024
Merged
@sbernauer sbernauer added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Jun 3, 2024
@sbernauer sbernauer changed the title Add labels to listener volume builder feat!: Add labels to listener volume builder Jun 3, 2024
Techassi added a commit that referenced this pull request Jun 3, 2024
@Techassi
Change version, mark #799 as breaking in changelog
ce9005b
github-merge-queue bot pushed a commit that referenced this pull request Jun 3, 2024
@Techassi
chore: Release stackable-operator 0.69.0 (#800)
9ff61fa 
* chore: Release stackable-operator 0.68.1

* Change version, mark #799 as breaking in changelog
@razvan razvan mentioned this pull request Jun 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhennig fhennig fhennig approved these changes

Assignees

@razvan razvan

Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razvan @fhennig @sbernauer