Generate NodePort address listings from PersistentVolume reservations #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightkr
commented
Oct 4, 2024
Comment on lines
225
to
233
| .list_with_label_selector::<PersistentVolume>( | ||
| &(), | ||
| &LabelSelector { | ||
| match_labels: Some(listener_persistent_volume_label(&listener).unwrap()), | ||
| ..Default::default() | ||
| }, | ||
| ) | ||
| .await | ||
| .with_context(|_| GetObjectSnafu { | ||
| obj: ObjectRef::<Endpoints>::new(&svc_name).within(ns).erase(), | ||
| })? | ||
| // Endpoints object may not yet be created by its respective controller | ||
| .unwrap_or_default(); | ||
| let node_names = endpoints | ||
| .subsets | ||
| .unwrap(); |
There was a problem hiding this comment.
This will only work with volumes that have been mounted at least once since upgrading.. maybe we want to merge the two mechanisms to help make migration more seamless?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #220, fixes #229.
This should make stable address listings.. stabler, since the PV "represents" the lifetime of the reservation.
Definition of Done Checklist
Author
Reviewer
Acceptance