This repository has been archived by the owner on Jun 10, 2018. It is now read-only.
Change rack session options only when asset is found #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If asset is not found, Rack will try next route since `X-Cascade` header is set. It is better do not change env when the request is pass through. [sporkd/asset_prefix_test](https://github.com/sporkd/asset_prefix_test) has demonstrated that when assets prefix is also a prefix of controller routes, the session is never stored.
|
Good point, but I'm just going to remove that entirely 5620203 |
This was referenced Apr 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If asset is not found,
RackRails will try next route sinceX-Cascadeheaderis set. It is better do not change env when the request is pass through.
sporkd/asset_prefix_test
has demonstrated that when assets prefix is also a prefix of controller
routes, the session is never stored.