Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new type condition #128

Closed
wants to merge 3 commits into from
Closed

feat: Add new type condition #128

wants to merge 3 commits into from

Conversation

philippwaller
Copy link
Contributor

By setting the type attribute in the label configuration, the user can specify whether a rule applies exclusively to Pull Requests (PRs) or Issues. This functionality increases the adaptability of this GitHub Action, allowing users to create more tailored labeling strategies that differentiate between PRs and Issues or apply universally to both.

By setting the type attribute in the label configuration, the user can specify whether a rule applies exclusively to Pull Requests (PRs) or Issues. This functionality increases the adaptability of this GitHub Action, allowing users to create more tailored labeling strategies that differentiate between PRs and Issues or apply universally to both.
@srvaroa
Copy link
Owner

srvaroa commented Dec 19, 2023

Thanks @philippwaller ! There is a conflict after merging the other PR but otherwise it LGTM

@philippwaller
Copy link
Contributor Author

Great, thank you for the quick processing @srvaroa!

@srvaroa
Copy link
Owner

srvaroa commented Dec 19, 2023

image

This is new! (strange it doesn't show the actual conflicts)

I'll to get the branch sorted locally and might repush to get it in

@srvaroa
Copy link
Owner

srvaroa commented Dec 19, 2023

Something must be going on due to the branch being in a fork. I have added the relevant commit straight to master, which generally makes GH recognize the change and close the PR as merged. But doesn't happen in this case.

I'll close, but your commit is in master. Release coming out shortly.

@srvaroa srvaroa closed this Dec 19, 2023
@srvaroa
Copy link
Owner

srvaroa commented Dec 19, 2023

@srvaroa
Copy link
Owner

srvaroa commented Dec 19, 2023

The Dockerfile @master now references v1.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants