Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Markdown chart can't be added to dashboard #304

Closed
EgorBu opened this issue Oct 17, 2019 · 6 comments · Fixed by #312
Closed

[bug] Markdown chart can't be added to dashboard #304

EgorBu opened this issue Oct 17, 2019 · 6 comments · Fixed by #312
Assignees
Labels
bug Something isn't working

Comments

@EgorBu
Copy link

EgorBu commented Oct 17, 2019

Hello,

When you create a markdown chart (I tried with only one of them) - after saving you can't find it when you are trying to modify the dashboard.
And when you are saving chart - you can't add it to a dashboard or create new dashboard.

@smacker
Copy link
Contributor

smacker commented Oct 17, 2019

For some reason, there are also 2 types of markdown charts. I tried with both none has worked.

@se7entyse7en se7entyse7en added the bug Something isn't working label Oct 17, 2019
@se7entyse7en se7entyse7en self-assigned this Oct 18, 2019
@se7entyse7en
Copy link
Contributor

I reproduced it too, and also there was already an issue asking for the differences between the markup and separator viz types, but it got no anwsers: link.

@se7entyse7en
Copy link
Contributor

Here's confirmation from maintainer that markup viz will be deprecated: link.
In the meantime, we could just avoid showing them when selecting the viz type just to avoid confusion.
@smacker wdyt?

@smacker
Copy link
Contributor

smacker commented Oct 18, 2019

If you don't mind, I would like to check the source code a bit later before making any decision.

About the deprecation, almost all current charts are going to be deprecated at some point (they already marked as legacy).
You can find issues about it in superset or superset-ui-plugins repo. But new shiny charts aren't going to happen any time soon.

@se7entyse7en
Copy link
Contributor

About the deprecation, almost all current charts are going to be deprecated at some point (they already marked as legacy).

Oh, I didn't know that 👍

If you don't mind, I would like to check the source code a bit later before making any decision.

sure! I remove myself as assignee.

@se7entyse7en se7entyse7en removed their assignment Oct 18, 2019
@smacker smacker self-assigned this Oct 22, 2019
@smacker
Copy link
Contributor

smacker commented Oct 22, 2019

So the reason why it can't be added to dashboard is here: apache/superset#5418 (comment)

It makes sense as in dashboards v2 once can add markdown using the dashboard UI itself.

I propose to remove it in our fork to avoid confusion as we don't need to maintain backward compatibility for those charts.

@smacker smacker mentioned this issue Oct 22, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants