Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASDF post #259

Merged
merged 6 commits into from
Nov 28, 2018
Merged

ASDF post #259

merged 6 commits into from
Nov 28, 2018

Conversation

vmarkovtsev
Copy link
Contributor

No description provided.

@vmarkovtsev vmarkovtsev changed the title [WIP] ASDF post ASDF post Oct 29, 2018
@vmarkovtsev
Copy link
Contributor Author

@campoy This is ready for your review. I cannot update staging since Friday night apparently, so here is the plain Markdown.

Fixes src-d#256

Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
content/post/asdf.md Show resolved Hide resolved
content/post/asdf.md Outdated Show resolved Hide resolved
---
author: vadim
date: 2018-11-10
title: "Advanced Scientific Data Format"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the title a bit more descriptive
Is this an "Introduction to Advanced Scientific Data Format" or something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Why we chose Advanced Scientific Data Format for ML models"

content/post/asdf.md Outdated Show resolved Hide resolved
content/post/asdf.md Show resolved Hide resolved
content/post/asdf.md Outdated Show resolved Hide resolved
content/post/asdf.md Outdated Show resolved Hide resolved
content/post/asdf.md Outdated Show resolved Hide resolved
content/post/asdf.md Outdated Show resolved Hide resolved
content/post/asdf.md Outdated Show resolved Hide resolved
@campoy
Copy link
Contributor

campoy commented Nov 6, 2018

Really nice post! Maybe I should write the go library as a fun project ...

Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
@vmarkovtsev
Copy link
Contributor Author

vmarkovtsev commented Nov 8, 2018

@drdavella @perrygreenfield do you have any suggestions or fixes over the ASDF description part? This post is scheduled for Nov. 26th so there is plenty of time to polish on my side. Link to the current text.

Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
@perrygreenfield
Copy link

This looks good to me. You might point out that Dan is working part time on a C++ implementation of the library (https://github.com/spacetelescope/asdf-cpp, and someone else started one that Dan has started to see if can be merged somehow: https://github.com/eschnett/asdf-cxx). Also, someone did a Go implementation, but it hasn't been maintained and doesn't appear to work, but it could be a starting point for someone else (https://github.com/astrogo/asdf). There is also an asdf paper that could be referred to but is a bit dated (https://www.sciencedirect.com/science/article/pii/S2213133715000645)

I'll think about it a bit and see if I have any other comments.

@drdavella
Copy link

It should be mentioned that both C++ libraries are very alpha but should be useable for basic use cases. I'm not sure that the Go implementation ever really got off the ground, but agree with @perrygreenfield that there's maybe enough there to prevent someone else from starting from scratch (cc @campoy).

Thanks so much for doing this!

content/post/asdf.md Outdated Show resolved Hide resolved
Copy link

@drdavella drdavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks really great! Thanks for doing this! Just one comment about credit below, and then a few questions that don't really have any bearing on the post itself.

Signed-off-by: Vadim Markovtsev <vadim@sourced.tech>
@vmarkovtsev
Copy link
Contributor Author

Thanks for your helpful comments @drdavella @perrygreenfield

Credits were updated, the paper linked, and the links to other implementations inserted.

@campoy This is finished.

content/post/asdf.md Outdated Show resolved Hide resolved
@campoy campoy self-assigned this Nov 28, 2018
Co-Authored-By: vmarkovtsev <vadim@sourced.tech>
@campoy campoy merged commit ed9e8c7 into src-d:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants