Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http to https for hyperlink #3762

Merged
merged 1 commit into from
Aug 6, 2023
Merged

http to https for hyperlink #3762

merged 1 commit into from
Aug 6, 2023

Conversation

vanillajonathan
Copy link
Contributor

No description provided.

jrfnl
jrfnl approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

I wonder if the codebase should get a complete review of all referenced URLs for http vs https (and outdated/broken links), but that's outside the scope of this PR.

@gsherwood gsherwood added this to the 3.8.0 milestone Mar 2, 2023
@jrfnl
Copy link
Contributor

jrfnl commented Aug 6, 2023

I wonder if the codebase should get a complete review of all referenced URLs for http vs https (and outdated/broken links), but that's outside the scope of this PR.

I've done this review now and found three more URLs which should be updated. I will submit a separate PR for those.

@jrfnl jrfnl merged commit a813c38 into squizlabs:master Aug 6, 2023
@jrfnl
Copy link
Contributor

jrfnl commented Aug 6, 2023

Thanks @vanillajonathan !

@vanillajonathan vanillajonathan deleted the patch-1 branch August 6, 2023 23:47
@jrfnl jrfnl mentioned this pull request Oct 28, 2023
Closed
5 tasks
@jrfnl jrfnl mentioned this pull request Nov 11, 2023
Merged
1 task
@jrfnl
Copy link
Contributor

jrfnl commented Dec 8, 2023

FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release.

As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredden fredden fredden approved these changes

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vanillajonathan @jrfnl @fredden @gsherwood