Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PHPCS annotations in multi-line tab-indented comments + not ignoring whole line for phpcs:set #1901

Merged
merged 5 commits into from
Feb 18, 2018
Merged

Fixed PHPCS annotations in multi-line tab-indented comments + not ignoring whole line for phpcs:set #1901

merged 5 commits into from
Feb 18, 2018

Commits on Feb 17, 2018

  1. Tokenizer/ErrorSuppression: add unit tests covering multi-line comments

    @jrfnl
    jrfnl committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    8640679 View commit details
    Browse the repository at this point in the history

  2. Tokenizer/ErrorSuppression: bugfix - tab indented annotations in mult… 

    …i-line block comments not recognized
    @jrfnl
    jrfnl committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    e815542 View commit details
    Browse the repository at this point in the history

  3. Tokenizer/ErrorSuppression: phpcs:set only ignore line when PHPCS a… 

    …nnotation is complete line

This fixes a situation where a `phpcs:set` could be used at the end of a line and the whole line was always being ignored.

```php
do_something(); //phpcs:set Standard.Category.Sniff propertyName value
```

I wasn't sure where to add a unit test for this as there did not seem to be any for `phpcs:set` in the `errorSuppression.Test.php` file.
    @jrfnl
    jrfnl committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    efae257 View commit details
    Browse the repository at this point in the history

  4. Tokenizer/ErrorSuppression: minor optimization

    @jrfnl
    jrfnl committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    6792680 View commit details
    Browse the repository at this point in the history

  5. Tokenizer/ErrorSuppression: fix minor typos in test file

    @jrfnl
    jrfnl committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    d9c6e9c View commit details
    Browse the repository at this point in the history