Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic.WhiteSpace.Disallow[Space/Tab]Indent not inspecting content before open tag #1762

Merged
merged 1 commit into from
Nov 27, 2017
Merged

Generic.WhiteSpace.Disallow[Space/Tab]Indent not inspecting content before open tag #1762

merged 1 commit into from
Nov 27, 2017

Commits on Nov 26, 2017

  1. WhiteSpace/DisallowSpace/TabIndent: bug fix - inspect complete file 

    Both these sniffs include `T_INLINE_HTML` in the `$checkTokens` array, but would only start checking the file **after** the first PHP open tag, so if a file - such as a view - would start with inline HTML and only have the first PHP open tag on line 5, the first 4 lines would not be inspected, nor fixed for tabs vs spaces.

I have not added unit tests for this as it would require to either renumber all the unit tests òr to add a second unit test file for both sniffs. If so desired, I'd be happy to make those changes, but it seemed a bit over the top for such a small change.
    @jrfnl
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    0b2d95d View commit details
    Browse the repository at this point in the history