Squiz/FunctionDeclarationArgumentSpacing: fix fixer conflict #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a function declaration contains comments, the `FunctionDeclarationArgumentSpacing` sniff would mistakingly see them as type hints, causing a fixer conflict between that sniff and the `PEAR.Functions.FunctionDeclaration`/`Squiz.Functions.MultiLineFunctionDeclaration` sniff. Includes unit test demonstrating the issue.
jrfnl
force-pushed
the
feature/squiz-functiondeclaration-argspacing-conflict
branch
from
258e80c
to
ba08109
Compare
|
Rebased for merge conflicts & updated code style... |
|
Thanks |
jrfnl
deleted the
feature/squiz-functiondeclaration-argspacing-conflict
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this error when running fixer conflict checks for the various standards. (See #1645 (comment) )
Fifth fix in a series to fix the issues found.
When a function declaration contains comments, the
FunctionDeclarationArgumentSpacingsniff would mistakingly see them as type hints, causing a fixer conflict between that sniff and thePEAR.Functions.FunctionDeclaration/Squiz.Functions.MultiLineFunctionDeclarationsniff.Includes unit test demonstrating the issue.