Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPCS erroneously identifying docblock as blank lines #1898

Closed
dhensby opened this issue Feb 15, 2018 · 2 comments
Closed

PHPCS erroneously identifying docblock as blank lines #1898

dhensby opened this issue Feb 15, 2018 · 2 comments
Milestone
3.2.3

Comments

@dhensby
Copy link
Contributor

dhensby commented Feb 15, 2018

When running PHPCS against a recent project using latest master (81c901f) the rule enforcing one blank line after the last use statement is failing.

The rule is reporting multiple blank lines when the last use statement is followed by a docblock.
This was referenced Feb 15, 2018
Merged
Merged
@jrfnl jrfnl mentioned this issue Feb 16, 2018
Merged
@skyzyx
Copy link

skyzyx commented Feb 17, 2018

Seeing this too, as of recently. I'm using c926d0b via the dev-master designation in Composer (which I need to use for a bugfix that occurred after v3.2.2 was cut).

gsherwood added a commit that referenced this issue Feb 18, 2018
@gsherwood
Changelog for #1898 + #1899 (ref #1893 + #1891)
47cdda1
@gsherwood
Copy link
Member

Closed by PR #1899

@gsherwood gsherwood added this to the 3.2.3 milestone Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.3
Development

No branches or pull requests
3 participants
@skyzyx @gsherwood @dhensby