Squiz/BlockComment: minor efficiency fixes

Don't duplicate function calls already made.
squizlabs · Feb 27, 2018 · a15dd0a · a15dd0a
1 parent c24f544
commit a15dd0a
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/Standards/Squiz/Sniffs/Commenting/BlockCommentSniff.php b/src/Standards/Squiz/Sniffs/Commenting/BlockCommentSniff.php
@@ -240,7 +240,7 @@ public function process(File $phpcsFile, $stackPtr)
                         $padding = str_repeat(' ', $expected);
                     }
 
-                    $phpcsFile->fixer->replaceToken($commentLines[1], $padding.ltrim($content));
+                    $phpcsFile->fixer->replaceToken($commentLines[1], $padding.$commentText);
                 }
             }//end if
 
@@ -300,20 +300,19 @@ public function process(File $phpcsFile, $stackPtr)
                         $padding = str_repeat(' ', $expected);
                     }
 
-                    $phpcsFile->fixer->replaceToken($line, $padding.ltrim($tokens[$line]['content']));
+                    $phpcsFile->fixer->replaceToken($line, $padding.$commentText);
                 }
             }//end if
         }//end foreach
 
         // Finally, test the last line is correct.
-        $lastIndex = (count($commentLines) - 1);
-        $content   = trim($tokens[$commentLines[$lastIndex]]['content']);
-        if ($content !== '*/' && $content !== '**/') {
+        $lastIndex   = (count($commentLines) - 1);
+        $content     = $tokens[$commentLines[$lastIndex]]['content'];
+        $commentText = ltrim($content);
+        if ($commentText !== '*/' && $commentText !== '**/') {
             $error = 'Comment closer must be on a new line';
             $phpcsFile->addError($error, $commentLines[$lastIndex], 'CloserSameLine');
         } else {
-            $content      = $tokens[$commentLines[$lastIndex]]['content'];
-            $commentText  = ltrim($content);
             $leadingSpace = (strlen($content) - strlen($commentText));
 
             $expected = ($starColumn - 1);