Skip empty types

squizlabs · Jun 8, 2023 · 8c84123 · 8c84123
1 parent c38bb12
commit 8c84123
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/Standards/Squiz/Sniffs/Commenting/FunctionCommentSniff.php b/src/Standards/Squiz/Sniffs/Commenting/FunctionCommentSniff.php
@@ -405,8 +405,12 @@ protected function processParams(File $phpcsFile, $stackPtr, $commentStart)
             $suggestedTypeNames = [];
 
             foreach ($typeNames as $typeName) {
+                if ($typeName === '') {
+                    continue;
+                }
+
                 // Strip nullable operator.
-                if (isset($typeName[0]) === true && $typeName[0] === '?') {
+                if ($typeName[0] === '?') {
                     $typeName = substr($typeName, 1);
                 }
 

diff --git a/src/Standards/Squiz/Tests/Commenting/FunctionCommentUnitTest.inc.fixed b/src/Standards/Squiz/Tests/Commenting/FunctionCommentUnitTest.inc.fixed
@@ -1050,7 +1050,7 @@ function throwCommentOneLine() {}
 /**
  * When two adjacent pipe symbols are used (by mistake), the sniff should not throw a PHP Fatal error
  *
- * @param stdClass||null $object While invalid, this should not throw a PHP Fatal error.
+ * @param stdClass|null $object While invalid, this should not throw a PHP Fatal error.
  * @return void
  */
 function doublePipeFatalError(?stdClass $object) {}
diff --git a/src/Standards/Squiz/Tests/Commenting/FunctionCommentUnitTest.php b/src/Standards/Squiz/Tests/Commenting/FunctionCommentUnitTest.php
@@ -116,6 +116,7 @@ public function getErrorList()
             1004 => 2,
             1006 => 1,
             1029 => 1,
+            1053 => 1,
         ];
 
         // Scalar type hints only work from PHP 7 onwards.