Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add listenbrainz plugin #258

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

carl-di-ortus
Copy link

@carl-di-ortus carl-di-ortus commented May 5, 2024

Listenbrainz support a compatibility for last.fm scrobbler, so a bare minimum adding this is very easy - just change the post URL. It copy-pastes ~300 lines of code. Dirty, but works. Better alternatives are a topic of discussion:

  • Add URL field in scrobbler settings (and rename old last.fm plugin to some more generic name like "Audio scrobble"?), this will not allow having multiple scrobblers at once.
  • Rename last.fm plugin to generic "Audio scrobble" and introduce a multiple url+username+password sets for handling sumbits. Might save the code duplication, but complicate settings a slight bit.
  • Keep plugin separate, and implement listenbrainz API, don't use listenbrainz proxy compatibility. This would still have code duplication on firing/listening events.
  • .. maybe more options?

Note: I'm basing this from #257, my original progress and more comments are tracked on forked repo - carl-di-ortus#2

I intend to keep this draft pull request hanging here, just to notify my intention, and gather feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant