Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation #437

Merged
merged 1 commit into from
Mar 15, 2016
Merged

German translation #437

merged 1 commit into from
Mar 15, 2016

Conversation

Goddchen
Copy link
Contributor

No description provided.

@MGaetan89
Copy link

You should not change that file, but rather create a new file in res/values-de/strings.xml with your translations in it.

@Goddchen
Copy link
Contributor Author

Oh damn... I know that of course. I should stop coding just after getting up in the morning ;) Will do it later today :)

@jrodbx
Copy link
Collaborator

jrodbx commented Mar 15, 2016

Thanks! Could you please squash the two commits and sign the CLA?

@Goddchen
Copy link
Contributor Author

Commits squashed and CLA signed :)

@pyricau
Copy link
Member

pyricau commented Mar 15, 2016

LGTM, however be advised that we won't maintain those strings. So any time a string changes, we'll have to remove the german translation and wait for someone to add that entry again.

jrodbx added a commit that referenced this pull request Mar 15, 2016
@jrodbx jrodbx merged commit 2757790 into square:master Mar 15, 2016
@Goddchen
Copy link
Contributor Author

Well, just let me know and I'll also update the translation :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants