Fix Strict mode violations #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .penaltyDeath() // | ||
| .build()); | ||
| StrictMode.setVmPolicy(new StrictMode.VmPolicy.Builder() // | ||
| .detectAll() // |
There was a problem hiding this comment.
One thing to note is that this detectAll() call enables some Activity reference counting. In my experience it gives quite a few false positives: http://stackoverflow.com/questions/21145261/strictmode-activity-instance-count-violation-2-instances-1-expected-on-rotati
Since LeakCanary monitors Activity leaks already, I've modified my StrictMode setup to manually enable everything except for the Activity counting:
StrictMode.setVmPolicy(new StrictMode.VmPolicy.Builder()
.detectLeakedClosableObjects()
.detectLeakedRegistrationObjects()
.detectLeakedSqlLiteObjects()
.penaltyLog()
.penaltyDeath()
.build());
There was a problem hiding this comment.
Excellent point. I actually looked at Strict mode when I started working on LeakCanary, I liked the idea but hated the implementation.
* Enable Strict Mode thread policy in the sample app. * Fixed violation when cleaning up files on startup. * Fixed violation when enabling components, the other side of the binder does IO operations. Fixes #15
pyricau
added a commit
that referenced
this pull request
May 12, 2015
Fix Strict mode violations. Fixes #15.
Yky
pushed a commit
to Yky/leakcanary
that referenced
this pull request
Feb 21, 2016
Fix Strict mode violations. Fixes square#15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15