Add "reason" and "fix" to ExcludedRef #365
Labels
Milestone
Comments
pyricau
added a commit
that referenced
this issue
Jan 8, 2016
* When creating an ExcludedRef rule, we can now provide a name for that rule and a reason. * When such a rule applies to an analysis result, it is stored in the leak trace element. * Also moved the lengthy comments in AndroidExcludedRefs to now be ExcludedRef reasons, embedded in LeakCanary. Fixes #365
pyricau
added a commit
that referenced
this issue
Jan 8, 2016
* When creating an ExcludedRef rule, we can now provide a name for that rule and a reason. * When such a rule applies to an analysis result, it is stored in the leak trace element. * Also moved the lengthy comments in AndroidExcludedRefs to now be ExcludedRef reasons, embedded in LeakCanary. Fixes #365
pyricau
added a commit
that referenced
this issue
Jan 8, 2016
* When creating an ExcludedRef rule, we can now provide a name for that rule and a reason. * When such a rule applies to an analysis result, it is stored in the leak trace element. * Also moved the lengthy comments in AndroidExcludedRefs to now be ExcludedRef reasons, embedded in LeakCanary. Fixes #365
pyricau
added a commit
that referenced
this issue
Jan 23, 2016
* When creating an ExcludedRef rule, we can now provide a name for that rule and a reason. * When such a rule applies to an analysis result, it is stored in the leak trace element. * Also moved the lengthy comments in AndroidExcludedRefs to now be ExcludedRef reasons, embedded in LeakCanary. Fixes #365
Pengchengxiang
pushed a commit
to XLibrarys/leakcanary
that referenced
this issue
Jan 2, 2017
* When creating an ExcludedRef rule, we can now provide a name for that rule and a reason. * When such a rule applies to an analysis result, it is stored in the leak trace element. * Also moved the lengthy comments in AndroidExcludedRefs to now be ExcludedRef reasons, embedded in LeakCanary. Fixes square#365
Pengchengxiang
pushed a commit
to XLibrarys/leakcanary
that referenced
this issue
Jan 2, 2017
* When creating an ExcludedRef rule, we can now provide a name for that rule and a reason. * When such a rule applies to an analysis result, it is stored in the leak trace element. * Also moved the lengthy comments in AndroidExcludedRefs to now be ExcludedRef reasons, embedded in LeakCanary. Fixes square#365
Pengchengxiang
pushed a commit
to XLibrarys/leakcanary
that referenced
this issue
Jan 2, 2017
* When creating an ExcludedRef rule, we can now provide a name for that rule and a reason. * When such a rule applies to an analysis result, it is stored in the leak trace element. * Also moved the lengthy comments in AndroidExcludedRefs to now be ExcludedRef reasons, embedded in LeakCanary. Fixes square#365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
AndroidExcludedRefs, we added a great length of comments explaining why we are ignoring the leak, and sometimes also suggesting a fix.Instead of comments, we should make those strings, and then pass those strings along in the
AnalysisResultif a leak is an ignored leak.The text was updated successfully, but these errors were encountered: