-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrading to implicit head that's already applied emits error message when it should likely pass silently, as is the case for normal heads already applied #336
Comments
Michael Bayer (@zzzeek) wrote: there's not a bug here I can see. Watch when we upgrade from total nothing to "heads" (please excuse my "python -m alembic.config" style, this is the same as just running "alembic"):
now we're at the branch 2 head. Notice that to get there, we had to apply "core 1". Core 1 is already applied. What would it mean to go there again? Just run "heads" - both heads are there:
"core" is known as the "effective head" because it is behind the branch, but if you were to make another version dependent on it, you'd be able to go to that as a head no problem:
the "effective head" term is discussed in http://alembic.readthedocs.org/en/latest/branches.html#branch-dependencies:
please confirm no issue on your end thanks! |
Michael Bayer (@zzzeek) wrote: I guess we could say the bug is that it should pass without an error message. So yes, that might be considered a fairly minor bug. I originally thought the issue was that the movement couldn't be made which would be a lot more serious. |
Changes by Michael Bayer (@zzzeek):
|
Changes by Michael Bayer (@zzzeek):
|
Michael Bayer (@zzzeek) wrote: Don't raise RangeNotAncestor for sibling branches Fixed bug where upgrading to the head of a branch which is already When we're about to claim an error due to Change-Id: I8641162bb05c6226f0ea12b88b548df41f5a6b51 → 2df9c52 |
Changes by Michael Bayer (@zzzeek):
|
Migrated issue, originally created by Cedric Shock
alembic 0.8.0 fails upgrades to a head that another branch
depends_on
.We are going to create the following revision graph.
Upgrading to
core@head
is successful until we upgrade tobranch@head
. After upgrading tobranch@head
, subsequent upgrades tocore@head
fail with the messageDestination core@head is not a valid upgrade target from current head(s)
.The following commands set up the desired revision graph.
Upgrading to
core@head
is successful multiple times in a row.We can upgrade to
branch@head
.But if we now try to upgrade to
core@head
again we get an error.The error is a result of
alembic.script.revision.RevisionMap.iterate_revisions
raisingRangeNotAncestorError
.The text was updated successfully, but these errors were encountered: