-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BatchOperations: create_primary_key and create_check_constraint #305
Comments
Michael Bayer (@zzzeek) wrote: probably only because they havent been tested. Can you try out this patch and let me know if it works rudimentally? I dont think special logic should be needed for check constraints. For the PK constraint, the Table object has to replace its already present PKC which I think it should do, so that "should" work also:
|
Changes by Michael Bayer (@zzzeek):
|
Changes by Michael Bayer (@zzzeek):
|
Felix Zumstein (@fzumstein) wrote: Hey thanks for the quick reply! The check constraint works, but the PK constraint ignores the name, i.e. it works but it creates an unnamed PK. |
Michael Bayer (@zzzeek) wrote:
→ 849996a |
Michael Bayer (@zzzeek) wrote:
→ a294f8c |
Changes by Michael Bayer (@zzzeek):
|
Michael Bayer (@zzzeek) wrote: primary key names are a little tricky as we don't support reflecting those names on most backends, but the batch mechanism will write it out if it has it. This is in master + a backport to 0.7.7 though at the moment it's not clear if 0.7.7 will just become 0.8.0. |
Migrated issue, originally created by Felix Zumstein (@fzumstein)
Is there a special reason these two methods are "not yet implemented"? Or are they planned?
The text was updated successfully, but these errors were encountered: