-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Build arm64 versions of Spyder's standalone macOS application #21766
Conversation
@mrclary, to fix the error on CIs you need to change the Python version in this line
to spyder/.github/workflows/installer-macos.yml Line 108 in a45cdf4
by changing the Python version there too and the name of the file |
And please also revert the version change you just did to py2app because it's not necessary. I mean, I fought a lot in PR #21629 to make our Github workflow work with more recent versions of py2app but I was unable to. |
* Update Python to 3.10.11 (arm64 builds not available for Python 3.9 from setup-python) * Update DMG name to include Spyder version and architecture
Thanks for the heads up; I almost went down that rabbit hole 😁. |
FYI, the glob pattern is identical for the Python 3.10.11 environment ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrclary!
Description of Changes
Add arm64 to build matrix
Note that py2app 0.28.5, I believe, should have updated the
black
recipe and resolved #19743. However, there is still an issue; see ronaldoussoren/py2app#518. The kluges from #21629 are still required.Fixes #20232
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: