Fix forgotten import for XMLUnit2 upgrade #1370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the XMLUnit2 upgrade was done (commit: c39d3d1) this import was forgotten. It causes the bug reported with XMLUnit1 (issue: spring-projects#1193) to still be present when using `ResultMatchers#soapEnvelope(Source)`. For more infos: spring-projects#1193 (comment) Here comes the fix for it.
|
@AntoineJT Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@AntoineJT Thank you for signing the Contributor License Agreement! |
|
Having the same issue, I'm looking forward to this fix ! |
gregturn
pushed a commit
that referenced
this pull request
Sep 5, 2023
When the XMLUnit2 upgrade was done (commit: c39d3d1) this import was forgotten. It causes the bug reported with XMLUnit1 (issue: #1193) to still be present when using `ResultMatchers#soapEnvelope(Source)`. For more infos: #1193 (comment) See #1370. Related: #1193.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the XMLUnit2 upgrade was done (commit: c39d3d1) this import was forgotten.
It causes the bug reported with XMLUnit1 (issue: #1193) to still be present in some cases when using
ResultMatchers#soapEnvelope(Source)(and thus withResultMatchers#soapEnvelope(Resource)too).For more infos: #1193 (comment)