Include MissingDeprecated in the default checks

Closes gh-420
spring-io · Jul 26, 2024 · 09679cc · 09679cc
1 parent cea1d86
commit 09679cc
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/...ormat.eclipse/src/io/spring/javaformat/eclipse/projectsettings/org.eclipse.jdt.core.prefs b/...ormat.eclipse/src/io/spring/javaformat/eclipse/projectsettings/org.eclipse.jdt.core.prefs
@@ -45,7 +45,7 @@ org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=enabled
 org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsVisibility=default
 org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore
 org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning
-org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=ignore
+org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=warning
 org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=ignore
 org.eclipse.jdt.core.compiler.problem.missingJavadocComments=ignore
 org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsOverriding=disabled

diff --git a/...ormat-checkstyle/src/main/resources/io/spring/javaformat/checkstyle/spring-checkstyle.xml b/...ormat-checkstyle/src/main/resources/io/spring/javaformat/checkstyle/spring-checkstyle.xml
@@ -22,6 +22,7 @@
 			<property name="elementStyle" value="compact" />
 		</module>
 		<module name="com.puppycrawl.tools.checkstyle.checks.annotation.MissingOverrideCheck" />
+		<module name="com.puppycrawl.tools.checkstyle.checks.annotation.MissingDeprecatedCheck" />
 		<module name="com.puppycrawl.tools.checkstyle.checks.annotation.PackageAnnotationCheck" />
 		<module name="com.puppycrawl.tools.checkstyle.checks.annotation.AnnotationLocationCheck">
 			<property name="allowSamelineSingleParameterlessAnnotation"

diff --git a/...ckstyle/src/test/java/io/spring/javaformat/checkstyle/SpringConfigurationLoaderTests.java b/...ckstyle/src/test/java/io/spring/javaformat/checkstyle/SpringConfigurationLoaderTests.java
@@ -16,8 +16,10 @@
 
 package io.spring.javaformat.checkstyle;
 
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.Properties;
 import java.util.Set;
 
@@ -49,17 +51,21 @@ public void loadShouldLoadChecks() {
 		TreeWalker treeWalker = (TreeWalker) checks.toArray()[4];
 		Set<?> ordinaryChecks = (Set<?>) Extractors.byName("ordinaryChecks").extract(treeWalker);
 		assertThat(ordinaryChecks).hasSize(61);
+		Set<?> commentChecks = (Set<?>) Extractors.byName("commentChecks").extract(treeWalker);
+		assertThat(commentChecks).hasSize(6);
 	}
 
 	@Test
 	public void loadWithExcludeShouldExcludeChecks() {
-		Set<String> excludes = Collections
-			.singleton("com.puppycrawl.tools.checkstyle.checks.whitespace.MethodParamPadCheck");
+		Set<String> excludes = new HashSet<String>(Arrays.asList("com.puppycrawl.tools.checkstyle.checks.whitespace.MethodParamPadCheck",
+				"com.puppycrawl.tools.checkstyle.checks.annotation.MissingDeprecatedCheck"));
 		Collection<FileSetCheck> checks = load(excludes);
 		assertThat(checks).hasSize(5);
 		TreeWalker treeWalker = (TreeWalker) checks.toArray()[4];
 		Set<?> ordinaryChecks = (Set<?>) Extractors.byName("ordinaryChecks").extract(treeWalker);
 		assertThat(ordinaryChecks).hasSize(60);
+		Set<?> commentChecks = (Set<?>) Extractors.byName("commentChecks").extract(treeWalker);
+		assertThat(commentChecks).hasSize(5);
 	}
 
 	@Test