Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audiobook Support and CI Workflow Update #1036

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

danhjoseph
Copy link
Contributor

@danhjoseph danhjoseph commented Oct 30, 2023

I have added audiobook support, users can now access single audiobooks, lists of audiobooks, and detailed chapter information. Additionally, I updated the CI workflow due to Python 2.7's sunset, the unavailability of Python 3.6 in GitHub Actions, and the lack of support for Python 2.7 in Ubuntu 20.04.

@stephanebruckert
Copy link
Member

Nice! A chance for added integration tests?

@danhjoseph
Copy link
Contributor Author

Yes, no problem. Integration tests will be added in the latest commit.

@danhjoseph
Copy link
Contributor Author

Is it possible to re-run the integration tests action? I've successfully passed the tests locally, and the same failing test passed in the previous commit. I suspect the problem may be due to a timeout issue between GitHub and Spotify.

Copy link
Member

@stephanebruckert stephanebruckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks a lot for the tests. I will look at some other PRs and try to release this soon

@stephanebruckert stephanebruckert merged commit 1416d47 into spotipy-dev:master Oct 31, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants