Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add IoCommands #72

Merged
merged 2 commits into from
Apr 13, 2016
Merged

add IoCommands #72

merged 2 commits into from
Apr 13, 2016

Conversation

nevillelyh
Copy link
Contributor

No description provided.

@nevillelyh
Copy link
Contributor Author

@ravwojdyla

@codecov-io
Copy link

Current coverage is 73.20%

Merging #72 into master will not affect coverage as of 2ea1826

@@            master    #72   diff @@
=====================================
  Files           61     61       
  Stmts         2004   2004       
  Branches       356    356       
  Methods          0      0       
=====================================
  Hit           1467   1467       
  Partial          0      0       
  Missed         537    537

Review entire Coverage Diff as of 2ea1826

Powered by Codecov. Updated on successful CI builds.

ravwojdyla
ravwojdyla reviewed Apr 11, 2016
View reviewed changes
scio-repl/src/main/scala/com/spotify/scio/repl/ScioILoop.scala
override def createInterpreter(): Unit = {
super.createInterpreter()
welcome()
intp.beQuietDuring {
addImports()
createBigQueryClient()
newScioCmdImpl("sc")
loadIoCommands()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should think about doing some of this stuff async to save on startup time? Probably doesn't make sense here (yet) - but I think spark and scala repls is doing some stuff in async fashion to help with startup time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be a huge difference? Let's not over optimize for now?

@nevillelyh
Copy link
Contributor Author

Let's keep it open now until there's a real need for this.

@ravwojdyla
Copy link
Contributor

👍

@nevillelyh nevillelyh merged commit 5828d5e into master Apr 13, 2016
@nevillelyh nevillelyh deleted the neville/repl-io branch April 13, 2016 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nevillelyh @codecov-io @ravwojdyla @sisidra