Fix redis examples #5482
Merged
Fix redis examples #5482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairemcginty
approved these changes
Sep 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5482 +/- ##
==========================================
- Coverage 61.30% 61.28% -0.02%
==========================================
Files 312 312
Lines 11070 11072 +2
Branches 773 758 -15
==========================================
Hits 6786 6786
- Misses 4284 4286 +2 ☔ View full report in Codecov by Sentry. |
RustedBones
approved these changes
Sep 12, 2024
| @@ -22,7 +22,34 @@ val elements: SCollection[(String, String)] = sc.redis(connectionOptions, keyPat | |||
|
|
|||
| Looking up specific keys from redis can be done with @scaladoc[RedisDoFn](com.spotify.scio.redis.RedisDoFn): | |||
|
|
|||
| @@snip [RedisExamples.scala](/scio-examples/src/main/scala/com/spotify/scio/examples/extra/RedisExamples.scala) { #RedisLookup_example } | |||
There was a problem hiding this comment.
should we go away from integrated snippets in the future?
There was a problem hiding this comment.
No, but they can't be in the Examples files. I think this was the only one and I added it only last year when doing doc cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing
Example:prefix needed to make redis example show up on the examples page, fixes usage formatting, moves documentation example into markdown to avoid it rendering as a header, removes scio-privateparDousage