Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use noOp cache instead of null when instantiating typedSparkeySideInput #5469

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

pgoggijr
Copy link
Contributor

@pgoggijr pgoggijr commented Sep 3, 2024

When attempting to access an element in a side input instantiated by typedSparkeySideInput where cache isn't specified, the following error is thrown since the cache is explicitly set to null:

Error message from worker: java.lang.NullPointerException: Cannot invoke "com.spotify.scio.util.Cache.get(Object, scala.Function0)" because the return value of "com.spotify.scio.extra.sparkey.instances.TypedSparkeyReader.cache()" is null
	com.spotify.scio.extra.sparkey.instances.TypedSparkeyReader.get(TypedSparkeyReader.scala:42)
	com.spotify.scio.extra.sparkey.instances.TypedSparkeyReader.get(TypedSparkeyReader.scala:31)

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.30%. Comparing base (2fe2258) to head (62a901b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...scala/com/spotify/scio/extra/sparkey/package.scala 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5469      +/-   ##
==========================================
- Coverage   61.31%   61.30%   -0.01%     
==========================================
  Files         312      312              
  Lines       11068    11070       +2     
  Branches      792      773      -19     
==========================================
+ Hits         6786     6787       +1     
- Misses       4282     4283       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RustedBones RustedBones merged commit 078519c into spotify:main Sep 5, 2024
11 checks passed
@pgoggijr pgoggijr deleted the use-no-op-cache branch September 5, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants