-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sbt-bom #5414
Use sbt-bom #5414
Conversation
build.sbt
Outdated
// slf4j-bom only available for v2 | ||
"org.slf4j" % "slf4j-api" % slf4jVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we absolutely need to downgrade to slf4j v1 as some deps are pulling v2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5414 +/- ##
==========================================
- Coverage 61.10% 61.09% -0.01%
==========================================
Files 310 310
Lines 11060 11060
Branches 769 769
==========================================
- Hits 6758 6757 -1
- Misses 4302 4303 +1 ☔ View full report in Codecov by Sentry. |
b8b5557
to
8b02d72
Compare
Use sbt-bom to pin beam, gcp and jackson versions
Leverage
sbt-bom
plugin and override versions forbeam
gcp
jackson
netty