Update FixAvroCoder to match transformed Avro SCollections #5351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairemcginty
commented
May 2, 2024
| .exists { | ||
| case TypeSignature(_, _, TypeRef(_, maybeAvroType, _)) => | ||
| AvroMatcher.matches(maybeAvroType) | ||
| case _ => false |
There was a problem hiding this comment.
I was getting a compiler warning about this line, so added the exhaustive matcher
RustedBones
reviewed
May 2, 2024
| package fix.v0_14_0 | ||
|
|
||
| import com.spotify.scio.values.SCollection | ||
| import com.spotify.scio.avro._ |
There was a problem hiding this comment.
why do we add the import here ? It is a false positive ?
There was a problem hiding this comment.
It is needed in this case -- without it, data.map(r => ("foo", r)) throws a Compilation error:
[error] /Users/clairem/scio/scalafix/output-0_14/src/main/scala/fix/v0_14_0/FixAvroCoder16.scala:9:13:
[error] Cannot find an implicit Coder instance for type:
[error]
[error] >> (String, fix.v0_14_0.A)
There was a problem hiding this comment.
I forgot A is not a generic type but a SpecificRecord 🤦♂️
There was a problem hiding this comment.
haha, we probably could have given it a better class name 😅
RustedBones
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Scalafix rule was missing utility-type classes that contain helper methods for SCollections, like:
This updates the rule to check for method that returns
SCollection[T <: SpecificRecord]. There's a tiny chance of a false positive if the method doesn't actually invoke any SCollection mapper functions but I don't think that usage is very common. I could update the method to inspect the function body for usage of functions with a Coder bound but I think that would be very error-prone