Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JacksonJsonpMapper as default for Elasticsearch #5306

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

kellen
Copy link
Contributor

@kellen kellen commented Mar 19, 2024

Fixes #4859

@kellen kellen marked this pull request as ready for review March 19, 2024 04:53
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.67%. Comparing base (67abe4a) to head (bcef0b7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5306      +/-   ##
==========================================
+ Coverage   62.65%   62.67%   +0.01%     
==========================================
  Files         301      301              
  Lines       10846    10848       +2     
  Branches      729      773      +44     
==========================================
+ Hits         6796     6799       +3     
+ Misses       4050     4049       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RustedBones RustedBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update ElasticsearchMinimalExample and ElasticsearchIOBehavior to leverage this change too ?

@kellen
Copy link
Contributor Author

kellen commented Mar 21, 2024

@RustedBones done.

@RustedBones RustedBones merged commit 6ebf9c4 into main Mar 21, 2024
11 checks passed
@RustedBones RustedBones deleted the kellen/es-default branch March 21, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide better default Json mapperFactory for saveAsElasticSearch
2 participants