Allow String key type to transform SMB sources with CharSequence key #5297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5297 +/- ##
==========================================
- Coverage 62.67% 62.66% -0.01%
==========================================
Files 301 301
Lines 10844 10844
Branches 749 749
==========================================
- Hits 6796 6795 -1
- Misses 4048 4049 +1 ☔ View full report in Codecov by Sentry. |
clairemcginty
commented
Mar 12, 2024
| @@ -403,11 +403,9 @@ private <MetadataT extends BucketMetadata> boolean isIntraPartitionCompatibleWit | |||
| final Class<? extends BucketMetadata> otherClass = other.getClass(); | |||
| final Set<Class<? extends BucketMetadata>> compatibleTypes = compatibleMetadataTypes(); | |||
|
|
|||
| if (compatibleTypes.isEmpty() && other.getClass() != this.getClass()) { | |||
| return false; | |||
| } else if (this.getKeyClass() != other.getKeyClass() | |||
There was a problem hiding this comment.
this check was not correct; it should have been comparing the metadata class itself.
Added an assertion in AvroBucketMetadataTest for this
kellen
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extension of #5291 for transforms.
+ adds support for sources with multiple partitions, where some partitions have CharSequence key and some have String key
( 🤦♀️ )