Implement hashCode() and equals() for FileOperations subclasses #5265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5265 +/- ##
=======================================
Coverage 62.72% 62.73%
=======================================
Files 301 301
Lines 10851 10859 +8
Branches 754 763 +9
=======================================
+ Hits 6806 6812 +6
- Misses 4045 4047 +2 ☔ View full report in Codecov by Sentry. |
shnapz
approved these changes
Feb 21, 2024
clairemcginty
commented
Feb 21, 2024
| } | ||
| final AvroFileOperations<ValueT> that = (AvroFileOperations<ValueT>) obj; | ||
| return that.getSchema().equals(this.getSchema()) | ||
| && that.codec.getCodec().toString().equals(this.codec.getCodec().toString()) |
There was a problem hiding this comment.
Context: CodecFactory has a specialized override of toString that prints the codec type.
kellen
pushed a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-consistent equals() seems to be an issue for FlinkRunner.