Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default coder for ResourceId #5244

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add default coder for ResourceId #5244

merged 1 commit into from
Feb 14, 2024

Conversation

clairemcginty
Copy link
Contributor

This is a fairly common type to pass around in transforms, let's add a Coder for it

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd8219a) 62.72% compared to head (913ad88) 62.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5244   +/-   ##
=======================================
  Coverage   62.72%   62.72%           
=======================================
  Files         301      301           
  Lines       10851    10851           
  Branches      739      739           
=======================================
  Hits         6806     6806           
  Misses       4045     4045           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clairemcginty clairemcginty merged commit 7392df0 into main Feb 14, 2024
11 checks passed
@clairemcginty clairemcginty deleted the resource-id-coder branch February 14, 2024 16:46
kellen pushed a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants