Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move populate test data to compile scope #5138

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

RustedBones
Copy link
Contributor

  • Leverage compile scope in integration project to populate test data and remove hack in GHA
  • Update comment helper in test with good command
  • Split PopulateTestData for jdbc

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e135ed2) 63.41% compared to head (39fbcb5) 63.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5138   +/-   ##
=======================================
  Coverage   63.41%   63.41%           
=======================================
  Files         291      291           
  Lines       10828    10828           
  Branches      737      737           
=======================================
  Hits         6867     6867           
  Misses       3961     3961           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clairemcginty clairemcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🙏 this is much cleaner!

@RustedBones RustedBones merged commit 9ed4ee4 into main Jan 8, 2024
11 checks passed
@RustedBones RustedBones deleted the fix-populate-test-data-cmd branch January 8, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants