Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow None for JDBC password #5081

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Allow None for JDBC password #5081

merged 1 commit into from
Nov 20, 2023

Conversation

kellen
Copy link
Contributor

@kellen kellen commented Nov 17, 2023

No description provided.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5778aa2) 63.17% compared to head (2bf3ee6) 63.17%.

❗ Current head 2bf3ee6 differs from pull request most recent head fa39163. Consider uploading reports for the commit fa39163 to get more accurate results

Files Patch % Lines
...cala/com/spotify/scio/jdbc/sharded/JdbcUtils.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5081   +/-   ##
=======================================
  Coverage   63.17%   63.17%           
=======================================
  Files         286      286           
  Lines       10785    10785           
  Branches      791      791           
=======================================
  Hits         6813     6813           
  Misses       3972     3972           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RustedBones RustedBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@RustedBones RustedBones merged commit 1155557 into main Nov 20, 2023
11 checks passed
@RustedBones RustedBones deleted the kellen/jdbc-null branch November 20, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants