Fix sending empty request when batch is empty #5060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
finishBundle
is called a call tocreateRequest
to send any remaining elements in the bundle in a single gRPC request. In some corner cases we can end up sending empty batch requests (with no elements) like in the following:Basically any time we reach the
finishBundle
and the batch queue is empty we send an empty batch request as we are not checking increateRequest
if there are elements or not.Changes
Only call
createRequest
infinishBundle
if there are still element in the batch queue.