Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make macro print debug logs if bigquery.types.debug enabled #5033

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

RustedBones
Copy link
Contributor

Right now, logging goes through slf4j, but there isn't any logger impl at compile time, giving

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementational 1s
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

use the macro front end to print debug statements

Comment on lines -50 to -51
debug(s"SchemaProvider.schemaOf[${typeOf[T]}]:")
debug(r)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this now covered elsewhere?

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #5033 (179431b) into main (fb3c27f) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

❗ Current head 179431b differs from pull request most recent head e74313d. Consider uploading reports for the commit e74313d to get more accurate results

@@            Coverage Diff             @@
##             main    #5033      +/-   ##
==========================================
- Coverage   63.12%   63.11%   -0.02%     
==========================================
  Files         286      286              
  Lines       10736    10733       -3     
  Branches      764      767       +3     
==========================================
- Hits         6777     6774       -3     
  Misses       3959     3959              
Files Coverage Δ
...potify/scio/bigquery/types/ConverterProvider.scala 100.00% <ø> (ø)
...m/spotify/scio/bigquery/types/SchemaProvider.scala 95.91% <100.00%> (-0.17%) ⬇️
...com/spotify/scio/bigquery/types/TypeProvider.scala 47.94% <ø> (ø)
...la/com/spotify/scio/bigquery/types/MacroUtil.scala 90.47% <0.00%> (-0.44%) ⬇️

@RustedBones RustedBones merged commit 0545de3 into main Oct 18, 2023
11 checks passed
@RustedBones RustedBones deleted the bigquery-types-debug branch October 18, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants